fix(gatsby-source-contentful): don't apply parent node links to child nodes #38728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: source-contentful
pieh
added a commit
that referenced
this pull request
Dec 4, 2023
… nodes (#38728) (#38730) * test: add test case asserting child nodes don't 'inherit' parent's links * fix(gatsby-source-contentful): don't apply parent node links to child nodes (cherry picked from commit be36b4a) Co-authored-by: Michal Piechowiak <[email protected]>
|
Released in |
This was referenced Dec 29, 2023
This was referenced Jan 5, 2024
This was referenced Jan 12, 2024
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some cases delta data update for contentful would result in bad child nodes being created/updated. This later result in warning like this:
and eventually in crash with following error:
This happens because when handling backreferences in delta data updates plugin currently applies
__NODEfields of parent node to child nodes which is wrong.First commit adds currently failing unit test case for this scenario. Second commit (yet to be pushed) will fix the issue.
Tests
Test case was added to unit tests
Related Issues
FRA-117